Skip to content
Hallway
0:00 / 0:00

#codereview#pygotham#michaellynch

How to Do Code Reviews Like a Human

PyGotham 2018

1.2K subscribers • 1 video on Hallway

YouTube
  • Recommended by 2 people: 2 in engineering communities.
  • Presented by Michael Lynch

Beginner. No background in the topic needed.

54K views8 years ago2 recommendations

Tools and practiceCareers and interviewsTestingCode review and teamworkDeveloper productivity

Michael Lynch shares practical techniques to improve communication, reduce conflict, and automate tedious parts of the code review process.

Speaker: Michael Lynch Are code reviews a source of tension on your team? Do they lead to conflict, bikeshedding, or wasted time? Most of the discussion we hear about code reviews is technical. We focus myopically on minimizing cost and maximizing bug discoveries. But reviews are as much a social exercise as a technical one. They’re an opportunity for teammates to share knowledge and bond through collaboration. That can’t happen if people are strangling each other over where to place the curly braces. In this talk, you’ll learn practical techniques your team can use to improve communication and minimize conflict during code reviews. I’ll talk about: * Reducing human effort of reviews through automation * Increasing your team’s review velocity * Giving sincere praise * Framing discussions for constructive debate * Mitigating stalemates

Why it's here

2 people recommend this

What people say. Recommended as a highly formative guide on how to conduct code reviews and mentor others constructively.

u/AssignedClassin r/ExperiencedDevs • Recommends

On “How to be a good mentor?”

This is probably the most formative piece of material I have in terms of mentoring: link to this video Beyond that though... I've only seriously mentored 3 people, but have had little mentoring ineractions with ~10. For me, mentoring feels like such a case-by-case situation that it's hard to say anything objective or concrete. > I don't want to jerk them around with some vague "I don't feel like you are quite there yet" You need to feel confident with your ability to make assessments on people as a mentor. As long as you can back things up with some guidance (here's what I think you need to do to move forward) and communicate with a "I'm ultimately just one person with one set of experiences" sort o…
3View on Reddit

u/AssignedClassin r/ExperiencedDevs • Recommends

On “How does one code review properly?”

Start here: link to this video Beyond that, it helps to have a set of team / company wide standards. It seems like you don't have that, but you might want to try and make this a side-objective as you do code reviews (have discussions, settle on common standards, and write down somewhere people can easily reference). The biggest thing to avoid is giving off the impression that the review your making is in service to your own ego, rather than trying to help the author do good work in relation to the rest of team / company (there's a lot of nuance to that though). > do you guys check the pull request on Github and see if it follows your guideline, or do you actually checkout the branch and then run it…
1View on Reddit

u/bluehavanain r/ExperiencedDevs • Recommends

On “How to give code reviews without offending other developers”

How to do Code Reviews Like a Human: [video By Michael Lynch
1View on Reddit